Fix django-stubs-ext missing breaking a production setup #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kakadus
approved these changes
Feb 5, 2024
|
Couldn't we just do from typing import TYPE_CHECKING, Any
if TYPE_CHECKING:
from django_stubs_ext import StrOrPromise
else:
StrOrPromise = Any |
This reverts commit 202a877.
richardebeling
changed the title
richardebeling
force-pushed
the
requirements
branch
from
cd5b712 to
bc36303
Compare
niklasmohrin
approved these changes
Feb 5, 2024
richardebeling
commented
Feb 5, 2024
niklasmohrin
approved these changes
Feb 8, 2024
richardebeling
force-pushed
the
requirements
branch
from
68f8a7d to
82176b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As django-stubs-ext is required so that
from django_stubs_ext import StrOrPromisedoesn't fail on production, but I also don't want to duplicate the dependency version number across two files.Opinions? Is there a better way? Maybe by specifying dependencies in pyproject.toml or something?